Feat bias autowater

[micahwoodard]

Pull Request instructions:

• Please follow the update protocol
• Answer the questions below in detail. Your responses will be emailed to experimenters.
• If the experimenters must do anything new, provide detailed step by step instructions on the wiki
• If computer maintainers need to manually update anything, provide detailed step by step instructions
• Use markdown syntax in order for your comments to be rendered reliably in the email: "1." instead of "1)", use four spaces for indents.
• If you use the keyword "skip email" in the title, it will skip the email updates
• Merges from "develop" into "production_testing" should use the keyword "production merge" in the title for reliable indexing of updates
• Merges from "production_testing" into "main" should use the keyword "update main"

Describe changes:

• treats bias watering like autowatering

What issues or discussions does this update address?

Describe the expected change in behavior from the perspective of the experimenter

Describe any manual update steps for task computers

Was this update tested in 446/447?

Does this update impact downstream processing by adding new saved files, or changing their format? If so, have you documented changes?

[micahwoodard]

@hanhou @alexpiet this is a pr to treat the bias watering algorithm like autowater. I wanted to get your eyes on it to make sure how I implemented works within the current framework for how auowater is handled. Thanks!

[alexpiet]

Are you setting the output of this logical_or to a variable?

[micahwoodard]

oh nice catch I meant to set to CurrentAutoRewardTrial

[alexpiet]

@micahwoodard it seems good to me, but I haven't tested it. Its been such a long time since I looked at this part of the code, I don't have much confidence in my review

[hanhou]

No apparent issues from my side. @XX-Yin could you please check if the new logic Micah implemented is compatible with our previous autowater algorithm?

@micahwoodard is it possible to use the simulation functionality (with some bias) to test it out?

[XX-Yin]

@micahwoodard @hanhou I haven’t caught up on this thread yet, but the simulation functionality should be working.