Open
Conversation
|
|
||
| class ReadS32HarpMessage(ReadHarpMessage): | ||
| def __init__(self, address: int): | ||
| super().__init__(PayloadType.S32, address) |
Collaborator
There was a problem hiding this comment.
This is a duplicate, no?
|
|
||
| def WriteS32Array(address: int, value: list[int]) -> WriteS32HarpMessage: | ||
| return WriteS32ArrayHarpMessage(address, value) | ||
|
|
Collaborator
There was a problem hiding this comment.
Should there be a matching ReadS32Array, for completeness and parity?
anjaldoshi
reviewed
Apr 21, 2025
| return int.from_bytes(self._frame[5:9], byteorder="little", signed=True) | ||
|
|
||
|
|
||
| class WriteU8ArrayMessage(WriteHarpMessage): |
There was a problem hiding this comment.
Should this be WriteU8ArrayHarpMessage instead of WriteU8ArrayMessage for naming consistency?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
WriteU8ArrayMessageso that we can write arrays per protocol spec (or write packed binary data).Let's merge #5 first.