Open
Conversation
This commit enhances the way DdbClassInfo handles types. It adds support for type interfaces by using a Stack to store them. This change ensures that all interfaces of a given type are correctly processed and taken into account.
A new entity MixedEntityFromInterface has been added along with its creation method in EntitiesFactory. This entity is being used in QueryEntityComparisonBenchmark for performance testing. The entity includes several properties like list, map, hashset and basic types.
Contributor
|
While I can see how this can be beneficial for someone, I'm not a fan of this feature in its current state. Currently, there is a simple rule - propertied with This PR breaks this "rule" and makes things more complicated. Since there is no |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings support to defining DynamoDb attributes on the interfaces instead of only classes. This doesn't happen by default on C# as attributes on interfaces are not projected to the classes that implement them. However, through some reflection we can get that information.
Example
Performance
However, I need somebody that knows how to use properly benchmarkdotnet to validate the results. I added a test case and I have no explanation for the numbers. I ran this many times and this implementation is somehow more performant... I honestly don't know how or why.