Replace TableNamePrefix with ITableNameFormatter for Better Flexibility#268
Open
icanhasjonas wants to merge 3 commits intoAllocZero:mainfrom
Open
Replace TableNamePrefix with ITableNameFormatter for Better Flexibility#268icanhasjonas wants to merge 3 commits intoAllocZero:mainfrom
TableNamePrefix with ITableNameFormatter for Better Flexibility#268icanhasjonas wants to merge 3 commits intoAllocZero:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the suggestion from issue #267
Currently, the API uses a
TableNamePrefixstring to modify table names. This works, but is inflexible.This PR introduces an
ITableNameFormatterinterface to handle table name resolution.This allows for:
Migration Path:
TableNamePrefixas[Obsolete]TableNamePrefixis set, internally create aPrefixTableNameFormatterto maintain compatibilityThis preserves backward compatibility while enabling greater extensibility.
Benchmark and Heap Alloc should have no- to minimal- effect. Size of passed argument (
string?orITableNameFormatter?) is the same. The formatter allows for non-heap formatting of table names (except for the simple formatter, which is more or less included for testing purposes)