fix: repair DeviceType enum in mknod to be hydrated from mode and rdev#96
Open
khanhtranngoccva wants to merge 2 commits intoAlogani:develfrom
Open
fix: repair DeviceType enum in mknod to be hydrated from mode and rdev#96khanhtranngoccva wants to merge 2 commits intoAlogani:develfrom
khanhtranngoccva wants to merge 2 commits intoAlogani:develfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the rdev field in the
mknodmethod. The originalrdevfield inlibfuseis 32 bits wide and supplies only the major (20 bits) and minor device number (12 bits) if the requested file type to create is a block device or a character device, but it does not really supply anything else, including the file type bits. The device numbers can be extracted usinglibc::majorandlibc::minor, and can be reconstructed usinglibc::makedev.EINVAL is returned in
mknodif the requested file mode cannot be mapped to a known file type.