Conversation
Zorag44
previously approved these changes
May 2, 2026
jangid
previously approved these changes
May 2, 2026
Contributor
jangid
left a comment
jangid
left a comment
There was a problem hiding this comment.
LGTM — clean feature addition. The transfer flow design is solid and security-critical logic is properly delegated to the on-chain Move contract.
Minor suggestions for follow-up:
- Remove the commented-out package ID in constants.ts
- The
addressparam is accepted but unused in the three build*Tx functions — either wire it up withsetSenderor remove it - Use the defined
ALPHAFI_TRANSFER_REQUEST_KEY_TYPEconstant instead of the hardcoded'TransferRequestKey'string in strategyContext.ts
Zorag44
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.