Bug fix when setting title for downloaded threads in some instances#1
Open
strnadchristopher wants to merge 1 commit intoAlteredAdmin:mainfrom
Open
Bug fix when setting title for downloaded threads in some instances#1strnadchristopher wants to merge 1 commit intoAlteredAdmin:mainfrom
strnadchristopher wants to merge 1 commit intoAlteredAdmin:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
When setting the title variable, handles the edge case in some threads where the topic post has no text field.
Why?
Encountered an issue with a certain thread in /wg/, which had no text attribute for some reason.
How?
When title variable is set, if there is no thread topic, it also checks if the thread topic has a text field before setting the variable to that text.
Testing?
Tested with that same thread, works fine now.