Small tweaks about user profiles, server settings and extraCountainer mount points. #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2- Made sure to include server settings in the cluster installation template 3- Added replacement logic for clickhouse-backup volumeMounts to bind to the created clickhouse volume
Collaborator
|
Thanks! Will review soon. |
…ar container(for example clickhouse-backup) 2- Added tests for the implementation 3- Added resources variable for clickhouse container inside values.yaml
Collaborator
|
Thank you for adding tests! |
- Use data PVC template name for mounts (fixes clickhouse-clickhouse-data mismatch)
- Preserve full extraContainers YAML and append mounts.data volumeMounts
- Add regression coverage for sidecar mounts and resources
2. Profiles/settings refactor + schema fixes
- Apply {{ .name }}/profile whenever profile is set
- Change users[].profile to string and add per‑user settings
- Add profiles section and schema validation (including _ in usernames)
- Set clickhouse.settings default to {} and sync schema/docs
Contributor
|
More changes added:
Notes / context
|
- Use data PVC template name for mounts (fixes clickhouse-clickhouse-data mismatch)
- Preserve full extraContainers YAML and append mounts.data volumeMounts
- Add regression coverage for sidecar mounts and resources
2. Profiles/settings refactor + schema fixes
- Apply {{ .name }}/profile whenever profile is set
- Change users[].profile to string and add per‑user settings
- Add profiles section and schema validation (including _ in usernames)
- Set clickhouse.settings default to {} and sync schema/docs
ups
# Conflicts: # tests/scenarios/smoke.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1- Added possibility to create a profile for each user.
2- Made sure to include server settings in the cluster installation template
3- Added replacement logic for clickhouse-backup volumeMounts to bind to the created clickhouse volume.