Allow any action to be checked with ["authContext"] expression #3954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the only allowed actions were 'instantiate' | 'confirm' | 'sign' | 'reject' | 'read' | 'write' | 'complete'. Now any action that backend think is relevant for the task (based on proces.pbmn). Unknown actions triggers a warning (even thogh they are on the previously accepted list). This is a change in behaviour for previously buggy apps that used eg. `["authContext", "reject"]` without specifying `reject` as an action in bpmn. Previously authContext returned false, but now the whole expression fails. I tested that vsCode understands the trick with `"anyOf": ["enum", "string"]` and provides suggestions from the enum but accept any action.
Contributor
📝 WalkthroughWalkthroughThe pull request broadens the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
olemartinorg
added
kind/product-feature
olemartinorg
approved these changes
Jan 19, 2026
Contributor
olemartinorg
left a comment
olemartinorg
left a comment
There was a problem hiding this comment.
I see a shared test is failing, you should probably fix that one and make sure the behavior matches the backend. 🙌 Otherwise this LGTM! 🙌
|
|
||
| const authContext = buildAuthContext(this.dataSources.process?.currentTask); | ||
| return Boolean(authContext?.[key]); | ||
| const hasAction = authContext?.[key]; |
Contributor
There was a problem hiding this comment.
I would probably call this hasPermissions instead. Now it reads like it contains a boolean that checks if the action exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the only allowed actions were 'instantiate' | 'confirm' | 'sign' | 'reject' | 'read' | 'write' | 'complete'.
Now any action that backend think is relevant for the task (based on proces.pbmn). Unknown actions triggers a warning (even thogh they are on the previously accepted list).
This is a change in behaviour for previously buggy apps that used eg.
["authContext", "reject"]without specifyingrejectas an action in bpmn. Previously authContext returned false, but now the whole expression fails.I tested that vsCode understands the trick with
"anyOf": ["enum", "string"]and provides suggestions from the enum but accept any action.Verification/QA
kind/*andbackport*label to this PR for proper release notes groupingSummary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.