Backport: Post place lookups: Using static file on CDN (#3947) #3956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replacing the zip code lookup (once again) with a single static registry file located on (soon to be) CDN, that we can download on-demand when we need to. This is more up-to-date than the package from NPM was, and we can keep it maintained across frontend versions without having to upgrade every app when there are changes upstream. * Bringing back the at least 4 and at most 5 assertion, as the test failed because there were 5 requests. It's probably something other than the post code lookup * Updating URL to use CDN --------- Co-authored-by: Ole Martin Handeland <git@olemartin.org>
olemartinorg
added
kind/bug
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
bjosttveit
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR in #3947. Backporting this manually since the auto-backport script failed as we were just about to release v4.25, and the auto-backport targeted v4.24 instead and got a merge-conflict.