Backporting: Fixing attachment removed in PATCH when process ends (#3953) #3964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* mapAttachments() hook returned no attachments when navigating to the receipt (i.e. changing taskId), since we get the process back earlier than we get new layouts. This should prevent node context effects from running while transitioning to a new task (essentially resetting NodesContext earlier than before). * This should fix the tests that broke (this was a bit sloppy) --------- Co-authored-by: Ole Martin Handeland <git@olemartin.org>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
olemartinorg
added
kind/bug
cammiida
approved these changes
Jan 22, 2026
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3953 for the original. This was backported in #3955, but because of a bug in the auto-backport workflow this was backported to v4.24 instead of v4.25.