Conversation
Deploying rainbow with
|
| Latest commit: |
8171cee
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a16ff5a2.rainbow-ctx.pages.dev |
| Branch Preview URL: | https://ts-6-preparation.rainbow-ctx.pages.dev |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the deprecated baseUrl setting from the app TypeScript configuration as part of aligning the repo with upcoming TypeScript changes.
Changes:
- Removed
compilerOptions.baseUrlfromtsconfig.app.json. - Updated the
#*path mapping target fromsrc/*to./src/*.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
3
to
6
| /* Path aliases */ | ||
| "baseUrl": ".", | ||
| "paths": { | ||
| "#*": ["src/*"] | ||
| "#*": ["./src/*"] | ||
| }, |
There was a problem hiding this comment.
compilerOptions.paths is present but baseUrl was removed. With the repo currently pinned to TypeScript 5.9.x, tsc -p tsconfig.app.json will error because paths cannot be used without baseUrl. Either keep baseUrl for now, remove paths and rely on package.json imports / Vite alias for # resolution, or upgrade TypeScript/config to a version that supports paths without baseUrl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://devblogs.microsoft.com/typescript/announcing-typescript-6-0/#deprecated:---baseurl