Skip to content

throw in session during render#81

Open
Amund211 wants to merge 1 commit intomainfrom
sentry-tweaks
Open

throw in session during render#81
Amund211 wants to merge 1 commit intomainfrom
sentry-tweaks

Conversation

@Amund211
Copy link
Copy Markdown
Owner

@Amund211 Amund211 commented Nov 9, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 9, 2025 13:43
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying rainbow with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5130119
Status: ✅  Deploy successful!
Preview URL: https://21a4f60a.rainbow-ctx.pages.dev
Branch Preview URL: https://sentry-tweaks.rainbow-ctx.pages.dev

View logs

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a debug line that throws an error when a specific localStorage item is not found. This appears to be temporary debugging code that was likely added during development to troubleshoot an issue.

Key Changes:

  • Added a localStorage check that throws an error for debugging purposes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

}),
);

if (!localStorage.getItem("lkjlkjlkjlk")) throw new Error("Debugging");
Copy link

Copilot AI Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be temporary debugging code that should be removed before merging. The localStorage key 'lkjlkjlkjlk' is meaningless and this check will throw an error in production, breaking the application for users.

Suggested change
if (!localStorage.getItem("lkjlkjlkjlk")) throw new Error("Debugging");

Copilot uses AI. Check for mistakes.
@Amund211
Copy link
Copy Markdown
Owner Author

Amund211 commented Nov 9, 2025

Errors during render are not being reported to sentry, it seems :^(

Also would be interesting to handle all uncaught exceptions outside of the render loop (e.g. event handlers)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants