Merged
Conversation
This commit refactors the experimental CLI to establish a robust and secure foundation for command-line interaction. The previous session-based model was unintuitive, unsuitable for scripting, and has been entirely replaced. The new design introduces a persistent, file-based PIN and restricts execution to the root user, laying the groundwork for all future CLI development. Key Changes: - **Persistent PIN Authentication:** - The CLI is now protected by a randomly generated PIN that is stored in LSPosed's configuration, surviving reboots. - The complex session timeout and notification-based PIN system has been completely removed. - **Script-Friendly Credentials:** - Authentication is now standard and predictable, using the `--pin` command-line argument or the `LSPOSED_CLI_PIN` environment variable for convenience in scripts. - **User-Friendly Helper Command:** - A `login` command has been added. It verifies the user's PIN and provides a convenient `export` command to set the environment variable for the current shell session. (cherry picked from commit a9afab6)
A file-based PIN can be easily abused by root users. In the future, we plan to allow shell users to run the CLI tool directly. (cherry picked from commit b7a112f)
(cherry picked from commit 46a9674)
(cherry picked from commit 97dd064)
(cherry picked from commit 0292779)
(cherry picked from commit f031cb2)
(cherry picked from commit 40cca34)
It seems that the module application itself is no longer (by default) in its scope list. (cherry picked from commit c600654)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.