Skip to content

fix: Invalid variant active_bids should be activate_bids #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Invalid variant active_bids should be activate_bids #66

wants to merge 1 commit into from

Conversation

@davidvuong
Copy link
Contributor

@davidvuong davidvuong commented Apr 27, 2022

The message fabrication for activateBids is incorrect. This PR renames active_bids to activate_bids. The following error occurs when trying to broadcast the malformed message:

failed to execute message; message index: 0: Error parsing into type moneymarket::liquidation_queue::ExecuteMsg: unknown variant `active_bids`, expected one of `receive`, `update_config`, `whitelist_collateral`, `update_collateral_info`, `submit_bid`, `retract_bid`, `activate_bids`, `claim_liquidation`

Documentation: https://docs.anchorprotocol.com/smart-contracts/liquidations/liquidation-queue-contract#activatebids

@davidvuong
fix: Invalid variant active_bids should be activate_bids
deabc46 
Documentation can be found here:

https://docs.anchorprotocol.com/smart-contracts/liquidations/liquidation-queue-contract#activatebids

Example payload:

{
  "activate_bids": {
    "collateral_token": "terra1...",
    "bids_idx": ["123","231"],
  }
}
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@davidvuong