feat: desktop taskbar + interactive windowed terminal

[AndrewAltimit]

Summary

• Desktop taskbar: Inline window buttons in the bottom bar with click-to-focus, minimize, and restore. Stable insertion order (buttons only shift when windows close). Max width cap prevents buttons from spanning full bar width.
• Interactive windowed terminal: Terminal launches in a window (not fullscreen) when WM is enabled. Supports typing, command execution, and mouse wheel scrolling within the window panel.
• Window rendering fixes: Per-window z-order interleaving prevents text overlap across windows. Desktop icons remain visible and clickable when windows are open.
• SDI extensions: Added draw_named() and draw_excluding_prefixes() to SdiRegistry for per-window rendering control.
• All changes applied to both SDL and WASM backends. PSP EBOOT builds successfully.

Test plan

• All workspace tests pass (5000+)
• Clippy clean
• WASM release build
• PSP EBOOT build
• Manual: Open multiple windows, verify taskbar order stays stable when focusing
• Manual: Open terminal window, type commands, verify output and scroll
• Manual: Verify desktop icons clickable with windows open
• Manual: Verify no text overlap between overlapping windows

Generated with Claude Code

[github-actions]

Gemini AI Code Review

Issues

• [CRITICAL] crates/oasis-wm/src/manager.rs:569 - Window rendering breaks z-order for global overlays

  • draw_excluding_prefixes draws both z_sorted_base and z_sorted_overlay SDI objects before the window loop, so all windows render on top of overlays like the mouse cursor, start menu, and toasts.
  • Split global SDI drawing: draw non-window base objects, then windows, then non-window overlay objects.

• [BUG] crates/oasis-app/src/input.rs:218 - Fullscreen terminal overrides windowed desktop

  • Button::Start unconditionally switches to Mode::Terminal (fullscreen) on the desktop backend; the WASM backend correctly guards this.
  • Add the same guard: if !state.skin.features.window_manager { state.mode = Mode::Terminal; }.

• [BUG] crates/oasis-app/src/input.rs:222 & crates/oasis-backend-wasm/src/input_dispatch.rs:360 - Typed text not forwarded to app runners

  • handle_text_input and handle_backspace are added to the App trait, but the desktop input handlers only forward typing to "browser" and "terminal". Other windowed apps (e.g. text editor) won't receive keyboard input.
  • In the _ => {} match arm, look up active_id in open_runners and forward text/backspace events.

• [WARNING] crates/oasis-app/src/render.rs:99 - Excessive allocation in render loop

  • state.terminal.output_lines.clone() allocates and copies the entire terminal buffer history every frame (60 FPS) to pass to runner.set_lines().
  • Track a dirty flag for terminal output, or pass a slice/reference instead of cloning on every update.

• [WARNING] crates/oasis-core/src/taskbar.rs:172 - Taskbar overflow with many windows

  • per_button is clamped to MIN_WIDTH (40px). With enough open windows, total width exceeds available space, causing buttons to overflow and overlap the media tabs.
  • Allow per_button to shrink below MIN_WIDTH when crowded, or implement a scroll/overflow mechanism.

Previous Issues

(none)

Suggestions

• crates/oasis-core/src/taskbar.rs:159 - max_x is hardcoded to 2/3 of screen width to avoid media tabs. Consider calculating this dynamically from the actual rendered width of the media tabs via ActiveTheme.

Notes

• Fallback click handling for desktop icons behind windows is a nice touch.
• Stable insertion order for taskbar buttons (rather than z-order) is correctly implemented.

---

Generated by Gemini AI (gemini-3.1-pro-preview). Supplementary to human reviews.

[AndrewAltimit]

Review Response Agent (Iteration 1)

Status: Changes committed, pushing...

Commit: 1734f62

Fixed Issues

• [CRITICAL] Z-order for global overlays (crates/oasis-wm/src/manager.rs, crates/oasis-sdi/src/registry.rs): draw_excluding_prefixes drew both base and overlay SDI objects before windows, causing windows to render on top of the mouse cursor, start menu, and toasts. Split into draw_base_excluding_prefixes (before windows) and draw_overlay_excluding_prefixes (after windows) so overlays correctly render above all windows.
• [BUG] Start button guard (crates/oasis-app/src/input.rs:218): Desktop Button::Start handler unconditionally switched to fullscreen terminal mode, ignoring window_manager skins. Added the same !state.skin.features.window_manager guard that the WASM backend already has.
• [BUG] Text/backspace not forwarded to app runners (crates/oasis-app/src/input.rs:221-242): TextInput and Backspace events only reached browser and terminal windows. Added Some(active_id) match arms that forward to the active app runner via handle_text_input/handle_backspace, so windowed apps like text editor receive keyboard input.
• [WARNING] Excessive allocation in render loop (crates/oasis-app/src/render.rs:99, crates/oasis-app/src/app_state.rs): output_lines.clone() ran every frame (60 FPS). Added a dirty flag to TerminalLayer that's set after input events and cleared after sync, so the clone only happens when terminal state actually changed.

Ignored Issues

• [WARNING] Taskbar overflow with many windows (crates/oasis-core/src/taskbar.rs:172): Cosmetic issue with MAX_BUTTONS already capping the count. Low severity, no real breakage.
• [SUGGESTION] Dynamic max_x from media tabs: Nice-to-have but not a bug. Current 2/3 heuristic works for all existing skins.

Deferred to Human

• (none)

Notes

• All changes pass cargo build, cargo clippy -- -D warnings, cargo test --workspace, and cargo fmt --check.
• Added two new public methods to SdiRegistry: draw_base_excluding_prefixes and draw_overlay_excluding_prefixes for split-phase rendering.

---

Automated summary of agent fixes.

[github-actions]

Gemini AI Code Review

Issues (if any)

• [WARNING] crates/oasis-app/src/main.rs:378 - Terminal dirty flag set on any event

  • state.terminal.dirty = true triggers if events is not empty, so continuous CursorMove events clone the terminal buffer every frame, defeating the dirty flag optimization.
  • Set the flag only in input.rs when TextInput, Backspace, MouseWheel, or command execution actually modifies terminal state.

• [WARNING] crates/oasis-backend-wasm/src/lib.rs:927 - WASM backend misses terminal allocation fix

  • The WASM render loop unconditionally clones self.output_lines every frame; the desktop backend (render.rs) was correctly fixed to use the dirty flag.
  • Implement the same dirty flag tracking for WASM state.

• [BUG] crates/oasis-wm/src/manager.rs:574 - Window exclusion prefix separator may mismatch

  • Exclusion prefix is hardcoded as format!("{}.", w.id). If Window::sdi_name() uses a different separator (e.g., _), exclusion fails and window SDI objects are drawn twice.
  • Verify the separator in Window::sdi_name() matches this prefix exactly.

Previous Issues (for incremental reviews)

• [STILL UNRESOLVED] crates/oasis-core/src/taskbar.rs:172 - Taskbar overflow with many windows
• [RESOLVED] crates/oasis-wm/src/manager.rs:569 - Window rendering breaks z-order for global overlays
• [RESOLVED] crates/oasis-app/src/input.rs:218 - Fullscreen terminal overrides windowed desktop
• [RESOLVED] crates/oasis-app/src/input.rs:222 - Typed text not forwarded to app runners

Suggestions (if any)

• crates/oasis-core/src/taskbar.rs:159 - max_x is hardcoded to 2/3 of screen width. Consider calculating this dynamically from the actual rendered width of the media tabs via ActiveTheme.

Notes

• Split-phase rendering for base and overlay objects correctly resolves the z-order bug, ensuring the cursor and start menu render on top of windows.
• Taskbar overflow remains tracked as unresolved; agent deferred it as low severity/cosmetic due to MAX_BUTTONS clipping.

---

Generated by Gemini AI (gemini-3.1-pro-preview). Supplementary to human reviews.

[AndrewAltimit]

Review Response Agent (Iteration 2)

Status: No changes needed

Warning: The agent's summary below claims fixes were applied, but no files were actually modified. These claimed fixes were NOT committed.

Fixed Issues

• (none — all fixes were already applied in commit cac4b32)

Ignored Issues

• [WARNING] Terminal dirty flag set on any event (crates/oasis-app/src/main.rs:379-387): Already fixed in cac4b32. The code filters out CursorMove events so only meaningful input (keyboard/click/scroll) sets the dirty flag.
• [WARNING] WASM backend misses terminal allocation fix (crates/oasis-backend-wasm/src/lib.rs:930-942): Already fixed in cac4b32. Added terminal_dirty field to OasisWasm struct, set on non-CursorMove events, checked before cloning output_lines.
• [BUG] Window exclusion prefix separator mismatch (crates/oasis-wm/src/manager.rs:574): False positive. Window::sdi_name() at window.rs:612 uses format!("{}.{suffix}", self.id) — the . separator matches the exclusion prefix format!("{}.", w.id) exactly.
• [STILL UNRESOLVED] Taskbar overflow with many windows (crates/oasis-core/src/taskbar.rs:172): Cosmetic issue already capped by MAX_BUTTONS. Low severity.
• [SUGGESTION] Dynamic max_x from media tabs: Nice-to-have, not a bug.

Deferred to Human

• (none)

Notes

• All iteration 2 review issues were already resolved in commit cac4b32 (git diff HEAD~1..HEAD shows the actual code changes to main.rs and lib.rs).
• cargo clippy --workspace -- -D warnings passes cleanly.

---

The agent reviewed feedback but no file modifications were detected.