fix: use weak import flag for sceVideocodec stubs#20
Merged
AndrewAltimit merged 1 commit intomainfrom Mar 7, 2026
Merged
Conversation
Change sceVideocodec psp_extern flags from 0x4001 to 0x4009, matching sceAudiocodec's flags. The 0x0008 bit marks the import as "weak", allowing modules to load even when the codec library hasn't been loaded yet via sceUtilityLoadModule. Without this fix, any EBOOT that references sceVideocodec functions fails to load on real PSP hardware because the kernel can't resolve the import stubs at module load time (the avcodec firmware module isn't loaded until runtime). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Gemini AI Code ReviewIssues(none) Previous Issues(none) Suggestions(none) Notes
Generated by Gemini AI (gemini-3-flash-preview). Supplementary to human reviews. |
Owner
Author
Review Response Agent (Iteration 1)Status: No changes needed Fixed Issues
Ignored Issues
Deferred to Human
Notes
The agent reviewed feedback but determined no code changes were required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Any EBOOT that references sceVideocodec functions fails to load on real PSP hardware because the kernel can't resolve the import stubs at module load time -- the avcodec firmware module isn't loaded until runtime via sceUtilityLoadModule(AvCodec).
sceAudiocodec already uses 0x4009 (weak) and works correctly with lazy module loading. sceVideocodec was the only codec using 0x4001 (strong).
Test plan
Generated with Claude Code (https://claude.com/claude-code)