Added Moko Resources#50
Open
JacquesSmuts wants to merge 6 commits intoAndroidDev-social:mainfrom
Open
Conversation
- Added SharedResources.kt with some samples for how to use Moko
- Added SharedResourcesTest.kt
- Fixed MastodonApiTests.kt and made it use .json files as resources.
# Conflicts: # data/network/build.gradle.kts # data/network/src/desktopTest/kotlin/social/androiddev/common/network/MastodonApiTests.kt # ui/common/build.gradle.kts
Contributor
|
@JacquesSmuts I apologize - I missed this PR. Can you please update and fix merge conflicts then request review from me? I can test this out locally as well as I have a Mac. Thanks! |
Contributor
|
what is the status of this pr? |
|
Now it's more relevant to use native compose resources instead of Moko |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 What does this PR do?
This PR adds Moko Resources to the repo, as well as a small sample to showcase its use.
This includes;
✅ Checklist
🧪 How can this PR been tested?
The tests I added should indicate that things are working to some degree, at least for the API tests, but I did not add a test to check the contents of the resource being accessed. Please let me know if you need me to do that.
🧾 Tasks Remaining: (List of tasks remaining to be implemented)
I don't have a MacBook and we don't have a ci up yet, so someone will please have to help make sure it works for iOS/mac.
I would just like feedback on this, please :)