Fix high CPU usage in simulators #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually just using some sleep commands while simulator is not null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Angel-125, first of all thank you for this awesome mod. I had some issues with the simulator (running KSP v1.10.1 on macOS Catalina). Actually with some sleep commands while simulator is not null in the thread routine seems to overcome the high CPU usage. I'm leaving the PR here in case you're interested.
I think a "better" solution would be to add some Wait mutexes, since the
Mutex.WaitOne()used here is not really doing his job. Probably my understanding is limited, but I think this could be a good start.Furthermore, reducing the sleeping period to ~20ms should be enough.