Try to fix structure inaccuracies.#1374
Open
JoshieGemFinder wants to merge 2 commits intoAngry-Pixel:1.12-fixesfrom
Open
Try to fix structure inaccuracies.#1374JoshieGemFinder wants to merge 2 commits intoAngry-Pixel:1.12-fixesfrom
JoshieGemFinder wants to merge 2 commits intoAngry-Pixel:1.12-fixesfrom
Conversation
Move to a factory-based way of creating biome decorators so a single one can't be broken by being used at several parts at the same time
Make it a lot simpler and cleaner (removed all of the yucky reflection in favour of a `FunctionalInterface`)
Collaborator
Author
|
I think probably this is more fixing potential race conditions than making it more consistent (which it does do a little bit) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move to a factory-based way of creating biome decorators so a single decorator can't be "broken" by being used to generate several parts at the same time (overwriting values from the original parts being generated with the values from the latest one).
This won't work for all cases, but I've had success in forcing: trees, bushes, idol heads, giant weedwood trees and a cragrock tower to stay consistent over two worlds with the same seed (they were not really that consistent before).