Conversation
✅ Deploy Preview for threejs-offset ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I've got a few things to check |
|
@AngyDev this PR is ready to go |
|
@andrewgremlich thank you, I'll review it in the weekend. Sorry at the moment I don't have the possibility to access to the code. |
|
Hi @andrewgremlich, when I try to run the test or the server, I'm getting this warning Do you have the same? If yes, could you fix it? |
|
Howdy @AngyDev ! Yup I'll take a look |
|
Huh, for some reason the order matters in this section in Also, I realized that those exports don't point to the dist folder. Would you like that? As well, I changed the nvmrc to point to the most recent node version (24). |
|
Yeah, the exports are only for the library. At this point, do we want to use version 25? |
|
We could use v25! I am initially against using it since it's not a designated LTS version. But since this isn't really an enterprise library, I guess it really doesn't matter. Thoughts? |
|
I was thinking the same. In this case, I don't think it is a big deal. Let's see what can happen 😅 |
As in let's go ahead with v25? I'm good with that |
|
@AngyDev this is ready to go I think |
|
@andrewgremlich Thanks for the updates! The new stuff looks good. Before we merge, can you revisit the older comments regarding the interfaces? |
I'm so sorry... I don't see a comment about interfaces... |
|
I'm so sorry, apparently I added the comments to the PR but never saved 😅 |
|
Thanks, @andrewgremlich, for the contribution 😊 |
Integrating Vitest first test suite.
#17