fix mypy errors#1248
Conversation
…orts Ruff I001 was failing because the typing import ran directly into the mashumaro import without a blank line separator. https://claude.ai/code/session_01K8GeVjG7MjJzhZMtrzRh48
Replace `lambda mid: {}` (which would crash with KeyError if the mock
were removed) with a proper empty notetype dict `{"css": "", "tmpls": []}`.
This removes the implicit dependency on the get_media_names_from_notetype
mock and makes each call site self-sufficient.
https://claude.ai/code/session_01K8GeVjG7MjJzhZMtrzRh48
Summary of ChangesHello @RisingOrange, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily addresses and resolves mypy type-checking errors across the codebase. The main approach involves explicitly casting notetype identifiers to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
* Remove aqt import from client models.py Refactor get_media_names_from_notetype to accept a note type dict instead of an ID, removing the aqt dependency from the client layer. Add a get_notetype_by_id callback parameter to get_media_names_from_notes_data so callers in the GUI/business layer provide the lookup function. https://claude.ai/code/session_01ENEZrvFPchRVdnATauZfo9 * Apply suggestion from @RisingOrange * Fix import formatting in models.py (#1247) * Fix import sorting: add blank line between stdlib and third-party imports Ruff I001 was failing because the typing import ran directly into the mashumaro import without a blank line separator. https://claude.ai/code/session_01K8GeVjG7MjJzhZMtrzRh48 * Remove fragile get_media_names_from_notetype mock in client tests Replace `lambda mid: {}` (which would crash with KeyError if the mock were removed) with a proper empty notetype dict `{"css": "", "tmpls": []}`. This removes the implicit dependency on the get_media_names_from_notetype mock and makes each call site self-sufficient. https://claude.ai/code/session_01K8GeVjG7MjJzhZMtrzRh48 --------- Co-authored-by: Claude <noreply@anthropic.com> * fix mypy errors (#1248) * Fix import sorting: add blank line between stdlib and third-party imports Ruff I001 was failing because the typing import ran directly into the mashumaro import without a blank line separator. https://claude.ai/code/session_01K8GeVjG7MjJzhZMtrzRh48 * Remove fragile get_media_names_from_notetype mock in client tests Replace `lambda mid: {}` (which would crash with KeyError if the mock were removed) with a proper empty notetype dict `{"css": "", "tmpls": []}`. This removes the implicit dependency on the get_media_names_from_notetype mock and makes each call site self-sufficient. https://claude.ai/code/session_01K8GeVjG7MjJzhZMtrzRh48 * Fix mypy errors: wrap mid with NotetypeId() for ModelManager.get() calls https://claude.ai/code/session_01K8GeVjG7MjJzhZMtrzRh48 --------- Co-authored-by: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
2 participants
Related issues
Proposed changes
Describe the big picture of your changes here to communicate to the reviewers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
How to reproduce
Explain like if someone who doesn't know this project is reviewing your changes and how they can replicate this.
Screenshots and videos
Paste here any screenshots or videos related to your changes, if applicable.
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...