Merged
Conversation
get arcadia block with proposer signature verification
NateAtNodeKit
force-pushed
the
tobfilter
branch
from
5508349 to
03810b2
Compare
bianyuanop
reviewed
Feb 19, 2025
bianyuanop
reviewed
Feb 19, 2025
NateAtNodeKit
force-pushed
the
tobfilter
branch
from
1e96fc6 to
c853ea5
Compare
NateAtNodeKit
force-pushed
the
tobfilter
branch
from
598166a to
48e4602
Compare
bianyuanop
reviewed
Feb 24, 2025
| // constructing RoB with txs from origin chain id | ||
| if opts.Txs == nil { | ||
| robTxs := ethtypes.Transactions{ | ||
| CreateEthTransfer(t, &opts.OriginChainID, testAccounts[0].PrivateKey, testAccounts[1].Address, 20, testAccounts[0].Nonce, 21000, nil), |
Contributor
There was a problem hiding this comment.
we may need to add a note to this that for every first RoB for one chain, testAccounts[0] is used and the tx nonce used is 0
Contributor
|
LGTM too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.