Open
Conversation
mtgnoah
reviewed
Mar 28, 2025
actions/src/transfer.rs
Outdated
|
|
||
| impl Transfer { | ||
| pub fn new(from_address: Address, to_address: Address, value: u64) -> Result<Transfer, TransferError> { | ||
| let empty_memo = b"".to_vec(); |
There was a problem hiding this comment.
Should transfer also have a type id? Also are we going to have both Transfer and SequncerMsg inherit properties from a common interface?
mtgnoah
reviewed
Mar 28, 2025
| } | ||
|
|
||
| impl<R: Rng + Spawner + Metrics + Clock> Router<R> { | ||
| const PATH_SUBMIT_BLOCK: &'static str = "/builder/submit"; |
There was a problem hiding this comment.
I don't think we need to have a submit block function here
mtgnoah
reviewed
Mar 28, 2025
storage/src/state_db.rs
Outdated
| pub struct StateDb { | ||
| db: Box<dyn Database>, | ||
| } | ||
| // can use like a redis from Arcadia like get and set for diff types? |
There was a problem hiding this comment.
Redis will introduce too much latency for this
mtgnoah
reviewed
Apr 1, 2025
types/src/units/msg.rs
Outdated
| pub chain_id: u64, | ||
| pub data: Vec<u8>, | ||
| pub from_address: Address, | ||
| pub relayer_id: u64, |
There was a problem hiding this comment.
@manojkgorle do we still need a relayer id ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.