Skip to content

Conversation

nick-leung
Copy link
Contributor


name: Pull Request
about: Propose changes to the codebase
title: '[PR] ' Avoid 'title' kwarg collision in examples and demo: rename column to 'task'
labels: ''
assignees: ''


Related Issue
This is related to the namespace collision pattern mentioned in discussions around issue #769.

Proposed Changes
Fixes a namespace collision in example apps where the model field name title conflicts with FastHTML's reserved title parameter used for setting HTML page titles in fast_app().

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist
Go over all the following points, and put an x in all the boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Copy link

gitnotebooks bot commented Aug 18, 2025

Review these changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/770

@nick-leung nick-leung changed the title Fix/rename-title-to-task [PR] Avoid 'title' kwarg collision in examples and demo: rename column to 'task' Aug 18, 2025
@johnowhitaker
Copy link
Contributor

Just ran them all with no issues - appreciate the fix!

@johnowhitaker johnowhitaker merged commit 7d0e613 into AnswerDotAI:main Aug 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants