Fix Download page image formatting to actually link to F-Droid and Google Play #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Hi @nathan-contino, Thanks a lot for spotting this and raising a PR! I had some other pending changes in #236 which would be incompatible with your PR, so I created another PR (with those pending changes and the correction needed) which will close your PR. We don't touch the translated pages as they're normally updated automatically by GitHub. Best |
|
Thanks! Good luck with the big 3.0 release tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I noticed that your download page is currently kinda broken. The URLs exist, but there's some broken markdown showing on the page itself. But you don't have to take my word for it: https://antennapod.org/download/
I took the liberty of fixing the issue (on all languages) by passing a URL argument to the image display code. Existing images that don't pass a URL will still display a modal exactly as before. But images that do pass a URL will now load that URL on click (instead of the modal).
I'm not sure if there's any hoops I have to jump through to get this contribution accepted, but let me know if I need to sign any agreements or adjust my commits to get this change in. Thanks!