Skip to content

chore(release): stage Cargo.lock without release asset#141

Open
dereknorrbom wants to merge 1 commit intomainfrom
develop
Open

chore(release): stage Cargo.lock without release asset#141
dereknorrbom wants to merge 1 commit intomainfrom
develop

Conversation

@dereknorrbom
Copy link
Copy Markdown
Contributor

Summary

  • Removes rust/Cargo.lock from python-semantic-release assets so it is not treated as a GitHub release upload.
  • Stages ../rust/Cargo.lock inside the semantic-release build command after cargo update regenerates the crate lock entry.
  • Keeps the release commit behavior without asking semantic-release to upload Cargo.lock as a release artifact.

Why

  • The 0.18.3 semantic-release run created the release commit/tag but failed when semantic-release tried to upload rust/Cargo.lock from the python/ working directory.
  • release.yml handles package publishing; semantic-release should only commit/tag version metadata here.

Validation

  • Parsed python/pyproject.toml with Python tomllib.
  • Confirmed tool.semantic_release.assets is no longer present.
  • git diff --check.

Expected Outcome

  • Future semantic-release runs can create tags/releases without failing on a missing rust/Cargo.lock asset.
  • rust/Cargo.lock remains included in semantic-release version commits.

Kanbus / Task Tracking

  • N/A

@dereknorrbom dereknorrbom requested a review from a team as a code owner April 29, 2026 00:54
@dereknorrbom dereknorrbom requested a review from endymion April 29, 2026 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant