chore(release): stage Cargo.lock without release asset#141
Open
dereknorrbom wants to merge 1 commit intomainfrom
Open
chore(release): stage Cargo.lock without release asset#141dereknorrbom wants to merge 1 commit intomainfrom
dereknorrbom wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rust/Cargo.lockfrom python-semantic-releaseassetsso it is not treated as a GitHub release upload.../rust/Cargo.lockinside the semantic-release build command aftercargo updateregenerates the crate lock entry.Why
0.18.3semantic-release run created the release commit/tag but failed when semantic-release tried to uploadrust/Cargo.lockfrom thepython/working directory.release.ymlhandles package publishing; semantic-release should only commit/tag version metadata here.Validation
python/pyproject.tomlwith Pythontomllib.tool.semantic_release.assetsis no longer present.git diff --check.Expected Outcome
rust/Cargo.lockasset.rust/Cargo.lockremains included in semantic-release version commits.Kanbus / Task Tracking