Skip to content

fix(reports): disable optional memory fanout for FeedbackAnalysis by default#204

Open
dereknorrbom wants to merge 1 commit intodevelopfrom
bugfix/feedback-analysis-empty-deque-from-days-mode
Open

fix(reports): disable optional memory fanout for FeedbackAnalysis by default#204
dereknorrbom wants to merge 1 commit intodevelopfrom
bugfix/feedback-analysis-empty-deque-from-days-mode

Conversation

@dereknorrbom
Copy link
Copy Markdown
Contributor

Summary

  • Update FeedbackAnalysis (legacy alias) to default memory_analysis to false unless explicitly configured.
  • Keep FeedbackAlignment behavior unchanged.
  • Add tests to verify:
  • default memory analysis is disabled for FeedbackAnalysis
  • explicit memory_analysis: true is preserved

Why

  • A production report using class: FeedbackAnalysis with days failed after score-result attachments with:
  • IndexError: pop from an empty deque
  • The failure occurs in async execution after heavy per-score processing; this change keeps legacy FeedbackAnalysis runs on the lightweight path by default and avoids optional memory-analysis fanout unless requested.

Validation

  • poetry run pytest -q plexus/reports/tests/test_feedback_analysis_alias.py -q
  • poetry run pytest -q plexus/reports/blocks/feedback_alignment_test.py -q

Expected Outcome

  • Existing FeedbackAnalysis reports (days/date-window) complete without invoking memory analysis unless explicitly opted in.
  • Users who want memory outputs can still enable them via memory_analysis: true.

Kanbus / Task Tracking

  • plx-e36b06

@dereknorrbom dereknorrbom requested a review from a team as a code owner April 23, 2026 20:38
@dereknorrbom dereknorrbom requested review from endymion and removed request for a team April 23, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants