revise readme for multiple host os by smartbit · Pull Request #20 · AnwarYagoub/RHCSA-RHCE-Lab-Environment

smartbit · 2016-11-15T23:39:49Z

Initial draft for revised README.md. Does not close #11 as Windows setup is TODO.

@AnwarYagoub Please reword/rewrite unclear sentences. Let me know what you think.

AnwarYagoub

sorry for late reply (as usual) I was busy last week.
I have don the following :

reviewed your changes & put in-line review in a couple of files.
test instructions on ubuntu.md file.

AnwarYagoub · 2016-11-16T05:04:20Z

+ssh-keygen -R 192.168.4.220; ssh-copy-id root@192.168.4.220
+vagrant halt                # shutdown all machines
+vagrant status              # all 4 have state poweroff
+vagrant snapshot save begin # create a VM snapshot


it is nice that you added a snapshot part

Thank you, in case of errors you can give it a clean start. Should also work on platforms other than Virtualbox.

Sander sometimes assumes changes made in previous chapters, sometimes he doesn't. IMHO a candidate RHCSA should be able to make a small script or flip back a few pages, to get on the same page were Sander assumes you are.

AnwarYagoub · 2016-12-02T08:04:09Z

-### 1. Install virtualbox :

-**1.1 Install virtualbox on Ubuntu:**
+## install Vagrant


heading should be Install Dependencies not install Vagrant because we are install both vagrant and virtualization hypervisors either kvm or virtualbox & the section above it in README.md should be called Dependencies.

Agree, see 373c8c7. Current Vagrantfile assumes Virtualbox, KVM hasn't been implemented yet.

AnwarYagoub · 2016-12-02T08:08:33Z

+wget -q -O - http://download.virtualbox.org/virtualbox/debian/oracle_vbox_2016.asc | sudo apt-key add -
+sudo sh -c 'echo "deb http://download.virtualbox.org/virtualbox/debian `lsb_release -sc` non-free contrib" > /etc/apt/sources.list.d/virtualbox.org.list'
+sudo apt-get update
+sudo apt-get install dkms


we can reduce the lines by put package names in one command:
sudo apt-get install git dkms virtualbox-5.1

Like 8058808?

smartbit · 2016-12-02T18:13:09Z

If you have time, please test. Eg. a clean install in a hypervisor with nested virtualisation support.

One day we should automate testing, but that is another story...

AnwarYagoub · 2016-12-02T18:09:40Z

+sudo reboot
+```
+
+```shell


@smartbit I think we can organize it better

# Generate SSH key to use when accessing machies ssh-keygen -t rsa -b 4096 -N "" -C "root@example.com" -f ~/.ssh/rhce # empty password # Make adding SSH key load to ssh agent automatic eval $(ssh-agent); echo $'eval $(ssh-agent)' >> ~/.profile ssh-add ~/.ssh/rhce; echo $'ssh-add ~/.ssh/rhce' >> ~/.profile # Add Virtualbox GPG Key & repository wget -q -O - http://download.virtualbox.org/virtualbox/debian/oracle_vbox_2016.asc | sudo apt-key add - sudo sh -c 'echo "deb http://download.virtualbox.org/virtualbox/debian `lsb_release -sc` non-free contrib" > /etc/apt/sources.list.d/virtualbox.org.list' # TODO remove linestarve.com and use alternative method to get latest version of vagrant # Add a repository to download vagrant sudo bash -c 'echo deb http://vagrant-deb.linestarve.com/ any main > /etc/apt/sources.list.d/wolfgang42-vagrant.list' sudo apt-key adv --keyserver pgp.mit.edu --recv-key AD319E0F7CFFA38B4D9F6E55CE3F3DE92099F7A4 # Update packages list sudo apt update # TODO remove virtualbox version-number and automatically install latest version; dkms needed when upgrading kernel # Install packages sudo apt -y --force-yes install virtualbox-5.1 git vagrant # virtualbox-ext-pack dkms # Download (clone) lab environment from GitHub cd ~ git clone https://github.com/AnwarYagoub/RHCSA-RHCE-Lab-Environment.git cd ~/RHCSA-RHCE-Lab-Environment

more comment is (almost) always better. Please push to the branch update_readme

Ok I will pull the latest changes and add comments.

AnwarYagoub · 2016-12-02T18:11:24Z

+
+```shell
+sudo apt update
+sudo apt -y --force-yes upgrade


Why using --force-yes man page for this command says:

--force-yes Force yes; this is a dangerous option that will cause apt to continue without prompting if it is doing something potentially harmful. It should not be used except in very special situations. Using force-yes can potentially destroy your system! Configuration Item: APT::Get::force-yes. This is deprecated and replaced by --allow-downgrades, --allow-remove-essential, --allow-change-held-packages in 1.1.

saw it, the --allow* descriptions and which to choose wasn't easy to find. Please suggest one.

Do we really need to force installing packages I can see why we need it !!

Probably not, now removed

AnwarYagoub · 2016-12-02T18:17:01Z

+wget -q -O - http://download.virtualbox.org/virtualbox/debian/oracle_vbox_2016.asc | sudo apt-key add -
+sudo sh -c 'echo "deb http://download.virtualbox.org/virtualbox/debian `lsb_release -sc` non-free contrib" > /etc/apt/sources.list.d/virtualbox.org.list'
+# TODO remove linestarve.com and use alternative method to get latest version of vagrant
+sudo bash -c 'echo deb http://vagrant-deb.linestarve.com/ any main > /etc/apt/sources.list.d/wolfgang42-vagrant.list'


This will make installing vagrant easy 👍

AnwarYagoub · 2016-12-02T18:34:05Z

If you have time, please test. Eg. a clean install in a hypervisor with nested virtualisation support.

I will try to do so. VirtualBox does not supprt nested virtualization check this link.

KVM may do it for us.

One day we should automate testing, but that is another story...

Definitely we should do so. I know nothing about test so I should read about it.

AnwarYagoub · 2016-12-06T17:58:14Z

+
+# Get vagrant version
+export virtualbox_version=`yum -y search VirtualBox | awk 'match($0, /(VirtualBox-[0-9]\.[0-9])/, a) {b=a[1]} END {print b}'`  # depends on yum sorting
+export virtualbox_version=`yum -y search VirtualBox | awk 'match($0, /(VirtualBox-[0-9]\.[0-9])/, a)  {if (RSTART)  { ++i; v[i]=a[1]}} END {n = asort (v); print v[n]}'`


@smartbit
why two exports with the same variable name virtualbox_version ?
the last one will override the first.

I was studying regex, sed & awk and came up with several alternatives. The other.md files have similar pairs and in c6bcfb3 you'll find even more alternatives.

What do you think, should we depend on the output order of yum & html pages, or should awk do the sorting? Any other suggestions, enhancements, questions, etc?

Ubuntu.md currently has three steps for installing vagrant:

download the .deb file

install it apt install ./vagrant_"$vagrant_version"_x86_64.deb

delete it rm ./vagrant_"$vagrant_version"_x86_64.deb

whereas in CentOS/Fedora it is a simple yum install https://...._x86_64.rpm. Do you know how to put the .deb-url on the apt install command-line directly?

What do you think, should we depend on the output order of yum & html pages, or should awk do the sorting? Any other suggestions, enhancements, questions, etc?

I mean when a user sees theses two command he/she may apply both of them. so why to put two of them if one can handle it properly

Ubuntu.md currently has three steps for installing vagrant:

download the .deb file
install it apt install ./vagrant_"$vagrant_version"x86_64.deb
delete it rm ./vagrant"$vagrant_version"_x86_64.deb

whereas in CentOS/Fedora it is a simple yum install https://...._x86_64.rpm. Do you know how to put the .deb-url on the apt install command-line directly?

If we want to install .deb we should use dpkg with -i option or any other alternative apt-get used to install packages from repositories unlike yum which can handle install a local package.

so why to put two of them if one can handle it properly

Because I didn't come to a conclusion which of the two (three) is better. What are your thoughts? After we made up our mind, we remove the other and have a reference left in the repository.

we should use dpkg with -i

Like this? It would put vagrant install on a single line, but then we'd have 2 lines for installing: dpkg for vagrant & apt install for git & virtualbox.
That would give 2 options 1) apt install & dpkg -i 2) download, apt install, rm. Which do you prefer?

This reverts commit d4eb9fb.

…dme_windows # Conflicts: # windows-vbx.md

Update readme windows

revise readme for multiple host os

9266817

AnwarYagoub reviewed Dec 2, 2016

View reviewed changes

smartbit added 2 commits December 2, 2016 18:52

updated instructions for installing on ubuntu 16.04

8058808

use heading 'Install Dependencies' not 'Install Vagrant'

373c8c7

AnwarYagoub reviewed Dec 2, 2016

View reviewed changes

removed --force-yes

de1aca6

AnwarYagoub and others added 5 commits December 2, 2016 21:45

add comments to supported platforms

16167a6

add missing comments

4f9a414

vagrant versioning error fixed, sudo added

c6bcfb3

vagrant versioning with both sed & awk

86b8481

automatically use latest version of vagrant & Vbox

13d9d94

AnwarYagoub reviewed Dec 6, 2016

View reviewed changes

smartbit and others added 8 commits December 7, 2016 17:22

added comment for hps:fsly.com?um_souce=hshicop &

abf33f2

added comment for $vagrant_version & $virtualbox_version

fe9e7bf

updated comment

e54e9bc

Added Microsoft Windows installation guide.

d4eb9fb

Revert "Added Microsoft Windows installation guide."

31c846a

This reverts commit d4eb9fb.

Added Microsoft Windows installation guide (Paragraph Enhanced).

66244b3

Merge remote-tracking branch 'upstream/update_readme' into update_rea…

5f86b8b

…dme_windows # Conflicts: # windows-vbx.md

Merge pull request #24 from adaroobi/update_readme_windows

d55de27

Update readme windows

Conversation

smartbit commented Nov 15, 2016

Uh oh!

AnwarYagoub left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smartbit Dec 2, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smartbit commented Dec 2, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AnwarYagoub Dec 2, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AnwarYagoub commented Dec 2, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

smartbit Dec 2, 2016 •

edited

Loading

AnwarYagoub Dec 2, 2016 •

edited

Loading