fix: #2 handle missing config file gracefully#56
Open
tarai-dl wants to merge 1 commit intoApexOpsStudio:mainfrom
Open
fix: #2 handle missing config file gracefully#56tarai-dl wants to merge 1 commit intoApexOpsStudio:mainfrom
tarai-dl wants to merge 1 commit intoApexOpsStudio:mainfrom
Conversation
- load_config() now creates default config when file is missing - Creates config directory automatically if needed - Added test for missing config scenario - All 3 tests pass Fixes ApexOpsStudio#2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2 — the app no longer crashes when
~/.config/task-cli/config.yamlis missing.Changes
load_config()now checks if config file exists before openingconfig.yaml.example)mkdir(parents=True, exist_ok=True).gitignorefor__pycache__/,*.pyc,.pytest_cache/Tests
test_load_config_missing_creates_default— verifies default config is created with correct contentHow to test
Fixes #2