Skip to content

VZ add multiprocessing to tranformer, update gitignore #6#6

Open
vickimzhang wants to merge 5 commits intomainfrom
vz-add-ssimpkg-gitignore
Open

VZ add multiprocessing to tranformer, update gitignore #6#6
vickimzhang wants to merge 5 commits intomainfrom
vz-add-ssimpkg-gitignore

Conversation

@vickimzhang
Copy link
Member

@vickimzhang vickimzhang commented Jan 19, 2026

  • add isStochasticTime=True to transformer to allow multiprocessing runs
  • add ssimpkg and metadata to gitignore
  • fix bug where the name of the datasheet, as defined in the model inputs, was incorrectly entered as "dataSheet" in the transformer
  • bump up one patch version

Summary by CodeRabbit

Release Notes

  • New Features

    • Transformers now support stochastic time configuration, enabling time-aware modelling scenarios and advanced simulation capabilities
  • Improvements

    • Package version updated to 2.1.2
  • Chores

    • Refined version control settings to exclude Visual Studio configuration files, project metadata directories, and package management artefacts for cleaner repository management

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 19, 2026

Walkthrough

Reintroduced and expanded .gitignore patterns; bumped src/package.xml version to 2.1.2, added isStochasticTime="True" to two transformer elements, and renamed several dataSheet identifiers and their layout references (InputDataSheet → InputDatasheet, IntermediateDataSheet → IntermediateDatasheet, OutputDataSheet → OutputDatasheet).

Changes

Cohort / File(s) Change Summary
Build configuration
/.gitignore
Reintroduces Visual Studio ignore entry *.vs/ (formatting adjusted); adds .metadata and *.ssimpkg ignore patterns.
Package manifest & public XML
src/package.xml
Version changed 2.1.12.1.2; added isStochasticTime="True" to transformer elements firstModel and secondModel; renamed dataSheet identifiers and all corresponding layout references: InputDataSheetInputDatasheet, IntermediateDataSheetIntermediateDatasheet, OutputDataSheetOutputDatasheet.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title mentions 'tranformer' (misspelled) and 'gitignore', but the main change involves multiprocessing support, version bumping, and naming corrections—only partially aligned with the actual changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @.gitignore:
- Around line 41-48: The .gitignore currently uses the pattern "*.vs/" which
does not match the actual .vs directory; update the ignore entry to ".vs/" so
the .vs folder (and its contents) are properly ignored, replacing the "*.vs/"
line with ".vs/" in the .gitignore file.

Comment on lines 41 to +48
# Visual studio
*.vs/ No newline at end of file
*.vs/

# Metadata
.metadata

# SyncroSim packages
*.ssimpkg
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix the Visual Studio ignore pattern so it actually matches .vs/.

Line 42 uses *.vs/, which won’t match the .vs/ folder (leading dot isn’t matched by *). Use .vs/ to prevent accidental commits.

🛠️ Proposed fix
-*.vs/
+.vs/
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# Visual studio
*.vs/
\ No newline at end of file
*.vs/
# Metadata
.metadata
# SyncroSim packages
*.ssimpkg
# Visual studio
.vs/
# Metadata
.metadata
# SyncroSim packages
*.ssimpkg
🤖 Prompt for AI Agents
In @.gitignore around lines 41 - 48, The .gitignore currently uses the pattern
"*.vs/" which does not match the actual .vs directory; update the ignore entry
to ".vs/" so the .vs folder (and its contents) are properly ignored, replacing
the "*.vs/" line with ".vs/" in the .gitignore file.

@vickimzhang vickimzhang changed the title vz add ssimpkg gitignore VZ add multiprocessing to tranformer, update gitignore #6 Jan 19, 2026
@vickimzhang vickimzhang marked this pull request as draft January 19, 2026 22:24
@vickimzhang vickimzhang marked this pull request as ready for review January 19, 2026 22:36
@vickimzhang vickimzhang requested a review from katieb1 January 19, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant