chore: suppress -Wdollar-in-identifier-extension compiler warning#589
Merged
janicduplessis merged 1 commit intoAppAndFlow:mainfrom Feb 18, 2025
Merged
Conversation
janicduplessis
approved these changes
Feb 18, 2025
Collaborator
janicduplessis
left a comment
janicduplessis
left a comment
There was a problem hiding this comment.
Thanks @kkafar !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following software-mansion/react-native-screens#2707
Variable names prefixed with
$are heavily utilised in codegened code. This leads to a wall of warnings popping up during every Android build. This PR aims to suppress these warnings.☝🏻 and that is not all...
Test Plan
Just build Fabric + Android with this change.