Merged
Conversation
runOnUI is async, so the registry may not be set up on the UI thread by the time NativeTransformerTextInputModule.install() runs, causing a crash when native code tries to access __rntti_registerTransformerRegistry. Switch to executeOnUIRuntimeSync to guarantee the registry exists before install() is called.
When defaultValue is set, Yoga measures the untransformed text for layout. The native-side transformation happens after layout and doesn't trigger a remeasure, resulting in incorrect sizing. Run the transformer worklet on the JS thread to pre-transform the defaultValue before passing it to the native TextInput, so Yoga measures the correct text from the start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.