Skip to content

Update client version to match kernel ouroboros#24

Merged
gabesullice merged 5 commits intomainfrom
fix-relationships-and-links
Jul 30, 2025
Merged

Update client version to match kernel ouroboros#24
gabesullice merged 5 commits intomainfrom
fix-relationships-and-links

Conversation

@zrpnr
Copy link
Contributor

@zrpnr zrpnr commented Jul 30, 2025

Objects like relatedLinks and menu have a data object that contains the actual array.
This restores the property so that array.map does not throw errors.

Also, links need to get the desired link type, e.g. myLink.get('canonical') or it also throws an error.

Seems like there is an issue with server side rendering however - it's displaying a 500 error in the markup now.
Maybe a mismatch with the way json is rendered in the SSR vs the client?

edit: I originally made fixes to match the use of client.js v2, however the server was using the latest ouroboros which was not present in that build of client. The fix here was to update to a newer client version, then the jsx didn't need any changes. See Applura/client#20

@zrpnr zrpnr requested a review from gabesullice July 30, 2025 01:57
@zrpnr
Copy link
Contributor Author

zrpnr commented Jul 30, 2025

Ah so my earlier changes were wrong, it wasn't the jsx that needed to be fixed it was the version of the client. The kernel was using the latest ouroboros but this intro project was including v2. I pulled down client and built a fresh dist and uploaded to AWS as v4.

@zrpnr zrpnr changed the title Restore properties for relationships and links Update client version to match kernel ouroboros Jul 30, 2025
@gabesullice gabesullice merged commit 0831942 into main Jul 30, 2025
@gabesullice gabesullice deleted the fix-relationships-and-links branch July 30, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants