Update client version to match kernel ouroboros#24
Merged
gabesullice merged 5 commits intomainfrom Jul 30, 2025
Merged
Conversation
Contributor
Author
|
Ah so my earlier changes were wrong, it wasn't the jsx that needed to be fixed it was the version of the client. The kernel was using the latest ouroboros but this intro project was including v2. I pulled down client and built a fresh dist and uploaded to AWS as v4. |
zrpnr
commented
Jul 30, 2025
gabesullice
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objects like relatedLinks and menu have adataobject that contains the actual array.This restores the property so that array.map does not throw errors.Also, links need togetthe desired link type, e.g.myLink.get('canonical')or it also throws an error.Seems like there is an issue with server side rendering however - it's displaying a 500 error in the markup now.Maybe a mismatch with the way json is rendered in the SSR vs the client?edit: I originally made fixes to match the use of client.js v2, however the server was using the latest ouroboros which was not present in that build of client. The fix here was to update to a newer client version, then the jsx didn't need any changes. See Applura/client#20