Integrate Perspective Transform module in ApraPipes#397
Open
shivaibhavd wants to merge 10 commits intomainfrom
Open
Integrate Perspective Transform module in ApraPipes#397shivaibhavd wants to merge 10 commits intomainfrom
shivaibhavd wants to merge 10 commits intomainfrom
Conversation
Contributor
Test Results Linux 1 files ± 0 1 suites ±0 10m 17s ⏱️ -1s For more details on these failures, see this check. Results for commit 2203627. ± Comparison against base commit d59bf55. This pull request removes 1 and adds 11 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Contributor
Test Results Win-nocuda 1 files ± 0 1 suites ±0 10m 34s ⏱️ +4s Results for commit 2203627. ± Comparison against base commit d59bf55. This pull request removes 1 and adds 11 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
mraduldubey
requested changes
Feb 27, 2025
| std::cout << "Transformation Matrix" << std::endl; | ||
| std::cout << mDetail->transformMatrix << std::endl; | ||
|
|
||
| cv::warpPerspective(mDetail->iImg, mDetail->oImg, mDetail->transformMatrix, mDetail->oImg.size()); |
Collaborator
There was a problem hiding this comment.
just create a wrapper in mDetail instead of making things public
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes ##396
Description
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Type Choose one: (Feature)
Screenshots (if applicable)
Checklist