Add DZK Bacnet Thermostat Accessory#27
Conversation
1. DzkZone object works 2. properly reads current temp current setpoint current humidity target heat/cool mode 3. current heat/cool mode may need work 4. setpoint changing needs work - which setpoint- heat or cool?
|
Hey, thank you a lot for the pull request. I've let the automated tests run and they've come up with some linting errors. Maybe you could look at that until I've got some more time on my hands ;) But don't feel obliged to it. |
|
Hi Benedikt, Thanks for the quick look. I have not used typescript before, so I was clearly breaking some of the rules regarding object and any. The latest commits show a clean lint. -Eric |
| bac_ob = "cold-set-point"; | ||
| break; | ||
| case DzkOperationMode.HEAT: | ||
| bac_ob = "heat-set-point"; |
There was a problem hiding this comment.
The switch statement seems to not be used. When returning, the calculations made in the switch statement aren't used. Is it meant to be this way?
| /** | ||
| * Characteristic "Target Fan State" | ||
| */ | ||
| class TargetFanState { |
There was a problem hiding this comment.
This seems to not be used. Only in commented out code. Is this meant to be removed oder is the commented out code meant to be not commented out?
| } | ||
| } | ||
| }, | ||
| "dzk-bacnet": { |
There was a problem hiding this comment.
This is used in homebridge ui. With the current configuration the output is always at minimum some JSON-Object. I think the user should be able to remove some item completely or at least an empty object or array.
{
"name": "BAChome Dynamic Platform",
"dzk-bacnet": {
"zones": [
{
"zone": 6
}
]
},
"platform": "bachome"
}
| { | ||
| "platform": "bachome", | ||
| "name": "BAChome Dynamic Platform", | ||
| "dzk-bacnet": { |
There was a problem hiding this comment.
This maybe needs some refactoring after updating the config.schema.json
3 participants
This adds support for the Daikin DZK-BACNET-3 zone controller - https://backend.daikincomfort.com/docs/default-source/product-documents/residential/brochures/pf-dzkbac.pdf?sfvrsn=80c62826_14
Highlights:
dzk-bacnet.ts module for Thermostat Accessories (one per zone). Config is simple - just need the IP address of the DZK unit and the names for each zone.
added a couple accessor methods to bacnet/bacnet.ts to simplify the bacnet requests.
added more types to the objectStringParser (Multistate objects, etc)