Skip to content

Fix incorrect material matching due to substring overlap #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
austenrt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix incorrect material matching due to substring overlap #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions HenryMod/Modules/Materials.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,11 @@ internal static class Materials
public static Material LoadMaterial(this AssetBundle assetBundle, string materialName) => CreateHopooMaterialFromBundle(assetBundle, materialName);
public static Material CreateHopooMaterialFromBundle(this AssetBundle assetBundle, string materialName)
{
materialName = materialName.Replace(" (Instance)", "");
Material tempMat = cachedMaterials.Find(mat =>
{
materialName.Replace(" (Instance)", "");
return mat.name.Contains(materialName);
string cachedName = mat.name.Replace(" (Instance)", "");
return cachedName == materialName;
});
if (tempMat) {
Log.Debug($"{tempMat.name} has already been loaded. returning cached");
Expand Down