Merged
Conversation
lanery
approved these changes
Jul 2, 2025
lanery
left a comment
lanery
left a comment
There was a problem hiding this comment.
Hey @keithchev all looks fine to me! Then again, I don't really know how the pyproject.toml has to be configured to work with the PyPI servers... best I could do is confirm that it matches the blocks in arcadia-pycolor as well as the poetry docs. Might want to ask for another set of eyes if you have any doubts.
Member
Author
Thanks! fwiw, I "tested" this in prod when I released a new version last week (v0.6.6), so it should be good 😎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the prod and test PyPI servers to
pyproject.toml. Their omission was essentially a bug introduced during the migration to poetry and pyproject.toml in #57.Drive-bys: