Skip to content

Add text descriptions to image only buttons usefull for screen reader users #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pvagner wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add text descriptions to image only buttons usefull for screen reader users #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c30d7e2
Add text descriptions to image only buttons usefull for screen reader…
pvagner Oct 24, 2025
e09c1c6
Fix code style
pvagner Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/components/FileItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,11 @@ export default function FileItem({ manager, file }: Props) {
background: "#32CD32",
};
return (
<button style={style} onClick={() => manager.exportFile(file)}>
<button
style={style}
onClick={() => manager.exportFile(file)}
aria-label="Share"
>
<MageDownload style={{ fontSize: "2em" }} />
</button>
);
Expand All @@ -77,6 +81,7 @@ export default function FileItem({ manager, file }: Props) {
<button
style={{ ...btnStyle, background: "#da342f" }}
onClick={() => manager.deleteFile(file.id)}
aria-label="Delete"
>
<MageTrash2Fill style={{ fontSize: "2em" }} />
</button>
Expand Down
2 changes: 1 addition & 1 deletion src/components/FilePicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export default function FilePicker({ manager }: Props) {

//console.log("FILE PICKER RERENDERED");
return (
<button onClick={onClick} style={pickerStyle}>
<button onClick={onClick} style={pickerStyle} aria-label="Add files">
<MagePlus style={{ verticalAlign: "middle" }} />
<input
type="file"
Expand Down