Potential fix for code scanning alert no. 9: Size computation for allocation may overflow#941
Open
Potential fix for code scanning alert no. 9: Size computation for allocation may overflow#941
Conversation
…ocation may overflow Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/ArcavenAE/ThreeDoors/security/code-scanning/9
Add an explicit upper-bound guard in
LevenshteinDistancebefore slice allocations solen(b)+1cannot overflow and cannot trigger impractically large allocations. The safest no-dependency approach is to cap input lengths usingmath.MaxIntarithmetic and return a conservative distance when inputs exceed safe bounds.Best single fix:
internal/core/duplicate_detector.go.math.LevenshteinDistance, after empty-string checks and beforemake, add:if len(b) > math.MaxInt-1 { return len(b) }ato keep behavior robust in loops:if len(a) > math.MaxInt-1 { return len(a) }This preserves existing functionality for normal inputs while preventing overflow at the flagged allocation site(s).
Suggested fixes powered by Copilot Autofix. Review carefully before merging.