feat: add Bootstrap carousel to login and register pages for enhanced UX#126
Open
SrinidhiPerala2104 wants to merge 11 commits intomainfrom
Open
feat: add Bootstrap carousel to login and register pages for enhanced UX#126SrinidhiPerala2104 wants to merge 11 commits intomainfrom
SrinidhiPerala2104 wants to merge 11 commits intomainfrom
Conversation
Collaborator
Author
|
@ArcueidShiki This PR is ready for review when you have time! Changes:
|
ArcueidShiki
requested changes
May 15, 2025
Owner
ArcueidShiki
left a comment
ArcueidShiki
left a comment
There was a problem hiding this comment.
It seems images not found at both login.html and register.html
- specify correct image path
- all the images at frontend should be placed under assets folder, and should be referenced by relative path
Collaborator
Author
|
@ArcueidShiki This PR is ready for review with:
Changes since last update:
|
ArcueidShiki
requested changes
May 15, 2025
Owner
ArcueidShiki
left a comment
ArcueidShiki
left a comment
There was a problem hiding this comment.
Did you test your codes,
All the input feids disappear
…name/password fields- Implemented password visibility toggle- Included remember me checkbox- Added form validation attributes
…name/password fields- Implemented password visibility toggle- Included remember me checkbox- Added form validation attributes
…sels- Preserved original input field styling classes- Maintained all carousel functionality- Ensured responsive behavior across devices- Verified all image paths are correct
Collaborator
|
please resolve the issue in login.html |
SrinidhiPerala2104
requested review from
Alice-Yuan0927,
Samradnyeess and
samradnyees
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhanced Carousel Feature
Asset Improvements