Skip to content

Finish Share function from my assets.html to chat.html#135

Merged
ArcueidShiki merged 3 commits intomainfrom
jingtong
May 16, 2025
Merged

Finish Share function from my assets.html to chat.html#135
ArcueidShiki merged 3 commits intomainfrom
jingtong

Conversation

@ArcueidShiki
Copy link
Copy Markdown
Owner

Description

Please include a summary of the change and which issue is fixed.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or my feature works
  • Lint and tests pass

Signed-off-by: ArcueidShiki <52120441+ArcueidShiki@users.noreply.github.com>
Signed-off-by: ArcueidShiki <52120441+ArcueidShiki@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 16, 2025 12:19
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request implements the share functionality to allow users to share their portfolio from the assets page to the chat page while also introducing various frontend UI improvements and backend updates for financial data retrieval.

  • Adds a user list modal and share button event handlers in the asset and portfolio components.
  • Updates ticker functionality and chat message handling (e.g., scrolling improvements).
  • Revises backend financials handling including dependency updates and migration changes.

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
frontend/toprank.html Minor HTML formatting fixes for CSS links.
frontend/ticker.html Commenting out unused tabs in the navigation.
frontend/myasset.html Updates to share button, currency text, and addition of a user modal.
frontend/js/ticker.js Adds the getFinancials function to fetch financial data.
frontend/js/myasset.js Implements functions for fetching users and handling share actions.
frontend/js/chat.js Introduces auto-scroll enhancements and removes unnecessary logs.
frontend/css/toprank.css & myasset.css Style adjustments including modal and layout improvements.
frontend/chat.html Cleans up hardcoded chat messages for dynamic chat rendering.
backend/requirements.txt Updates dependencies to support new features.
backend/migrations/versions/3186032311b0_financial.py Adds new financial columns and constraints with some naming issues.
backend/app/utils/polygontool.py Updates method signature to fetch financials by symbol.
backend/app/models/db.py Updates USCompany financials mapping and financials model definition.
backend/app/controllers/stock_controller.py Revises overview and financials endpoints with improved error handling.
TODO Adds new roadmap items including chat feature and UI improvements.
Comments suppressed due to low confidence (2)

backend/app/controllers/stock_controller.py:364

  • Typo in column name 'copmany_id'; it should be 'company_id' to match the model definition.
copmany_id=company.id,

backend/migrations/versions/3186032311b0_financial.py:28

  • The column name 'labal' appears to be misspelled; consider renaming it to 'label' for clarity and consistency with its intended purpose.
batch_op.add_column(sa.Column('labal', sa.String(length=100), nullable=False))

Comment thread backend/app/models/db.py
quarter = financial.fiscal_period
type = financial.type
sub_type = financial.sub_type
financialsMap[year][quarter][type][sub_type] = financial.to_dict()
Copy link

Copilot AI May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nested dictionary 'financialsMap' is used without initializing its nested keys, which can lead to runtime errors when assigning values. Consider initializing each level (e.g., using conditional checks or a helper function) before assignment.

Copilot uses AI. Check for mistakes.
Signed-off-by: ArcueidShiki <52120441+ArcueidShiki@users.noreply.github.com>
@ArcueidShiki ArcueidShiki linked an issue May 16, 2025 that may be closed by this pull request
@ArcueidShiki ArcueidShiki merged commit 3f7eb1d into main May 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Share Function of Portfolio

2 participants