Allow pre-selecting vehicle, version, and board via URL parameters by ryanbasic1 · Pull Request #229 · ArduPilot/CustomBuild

ryanbasic1 · 2026-02-14T17:07:10Z

Adds support for pre-selecting vehicle, version, and board from URL parameters.

Example:

?vehicle=copter&version=stable&board=pixhawk

Details

Frontend-only change
No backend changes required
Safe fallback if parameters are invalid
Does not affect existing behavior

This allows external links to directly open pre-configured build ### ### selections.

Closes #181

Adds support for pre-selecting vehicle, version, and board from URL parameters. Example: ?vehicle=copter&version=stable&board=pixhawk - Frontend-only change - No backend changes - Safe fallback if parameters are invalid - Does not affect existing behavior This allows external links to directly open pre-configured build selections.

shiv-tyagi · 2026-02-14T17:10:47Z

This PR still has huge diff. I will suggest you to get to the root cause instead of resubmitting the PR.

Do not close existing PR. The same branch after fixing things in this PR itself.

You need to get rid of your last commit I think.

Please check diff before pushing.
Stop blindly trusting that AI please.

shiv-tyagi

Thanks for contributing. The direction is correct. It just needs a little more polishing. PTAL.

shiv-tyagi · 2026-02-15T04:54:21Z

web/static/js/add_build.js

    if (typeof rebuildFromBuildId !== 'undefined') {
        await initRebuild(rebuildFromBuildId);
+    } else {
+        initFromUrlParams();


Can we rename initRebuild to initPreSelect and do both in same function (and get rid of initFromUrlParams altogether). We first check if rebuild_from param is there, if not we check vehicle_id, board_id and version_id are present, and set those properties.

The only difference would be that we would not be setting selected_features[], in second case.

I merged the rebuild and URL param logic into a single initPreSelect() function and removed initFromUrlParams().
Thank you

shiv-tyagi · 2026-02-15T04:55:05Z

web/static/js/add_build.js

+    if (params.has('vehicle')) rebuildConfig.vehicleId = params.get('vehicle');
+    if (params.has('board')) rebuildConfig.boardId = params.get('board');
+    if (params.has('version')) rebuildConfig.versionId = params.get('version');


Suggested change

if (params.has('vehicle')) rebuildConfig.vehicleId = params.get('vehicle');

if (params.has('board')) rebuildConfig.boardId = params.get('board');

if (params.has('version')) rebuildConfig.versionId = params.get('version');

if (params.has('vehicle_id')) rebuildConfig.vehicleId = params.get('vehicle');

if (params.has('board_id')) rebuildConfig.boardId = params.get('board');

if (params.has('version_id')) rebuildConfig.versionId = params.get('version');

Let us call it vehicle_id and similar at all places.

Updated to use vehicle_id, version_id and board_id consistently for URL parameters.

Thanks for pointing this out.

shiv-tyagi · 2026-02-15T04:55:29Z

web/static/js/add_build.js

+    if (params.has('version')) rebuildConfig.versionId = params.get('version');
+
+    // Set flag to indicate URL parameters were provided
+    rebuildConfig.fromUrlParams = hasParams;


Can this be avoided? This won't be needed if we have a common error handling as described in the other comment.

shiv-tyagi · 2026-02-15T04:57:07Z

web/static/js/add_build.js

+                    if (rebuildConfig.isRebuildMode) {
+                        console.warn(`Rebuild vehicle '${rebuildConfig.vehicleId}' not found in available vehicles`);
+                        alert(`Warning: The vehicle from the original build is no longer available.\n\nRedirecting to new build page...`);
+                        window.location.href = '/add_build';
+                        return;
+                    } else if (rebuildConfig.fromUrlParams) {
+                        console.warn(`URL parameter vehicle '${rebuildConfig.vehicleId}' not found. Defaulting to first available vehicle.`);
+                        rebuildConfig.vehicleId = null;
+                    } else {
+                        rebuildConfig.vehicleId = null;
+                    }


Can we have one common error message for both cases? That way we can also avoid multiple if-else cases.

Maybe something like, "Vehicle XXX is no longer listed for building. Redirecting to new build page...".

yes added a common error message for both case ! ###

shiv-tyagi · 2026-02-15T04:58:05Z

web/static/js/add_build.js

+                    if (rebuildConfig.isRebuildMode) {
+                        console.warn(`Rebuild board '${rebuildConfig.boardId}' not found for version '${version_id}'`);
+                        alert(`Warning: The board from the original build is no longer available.\n\nRedirecting to new build page...`);
+                        window.location.href = '/add_build';
+                        return;
+                    } else if (rebuildConfig.fromUrlParams) {
+                        console.warn(`URL parameter board '${rebuildConfig.boardId}' not found for version '${version_id}'. Defaulting to first available board.`);
+                        rebuildConfig.boardId = null;
+                    } else {
+                        rebuildConfig.boardId = null;
+                    }


Similar to the other comment for vehicles.

shiv-tyagi · 2026-02-15T04:58:17Z

web/static/js/add_build.js

+                    if (rebuildConfig.isRebuildMode) {
+                        console.warn(`Rebuild version '${rebuildConfig.versionId}' not found for vehicle '${new_vehicle_id}'`);
+                        alert(`Warning: The version from the original build is no longer available.\n\nRedirecting to new build page...`);
+                        window.location.href = '/add_build';
+                        return;
+                    } else if (rebuildConfig.fromUrlParams) {
+                        console.warn(`URL parameter version '${rebuildConfig.versionId}' not found for vehicle '${new_vehicle_id}'. Defaulting to first available version.`);
+                        rebuildConfig.versionId = null;
+                    } else {
+                        rebuildConfig.versionId = null;
+                    }


Similar to the other comment for vehicles.

… handling

shiv-tyagi · 2026-02-17T12:26:16Z

web/static/js/add_build.js

    function updateGlobalCheckboxState() {
        const total_options = Object.keys(features_by_id).length;
        let global_checkbox = document.getElementById("check-uncheck-all");
+        if (!global_checkbox) return;


shiv-tyagi · 2026-02-17T12:26:28Z

web/static/js/add_build.js

+async function initPreSelect() {
+  const params = new URLSearchParams(window.location.search);
+
+  // Rebuild flow ---


Suggested change

// Rebuild flow ---

shiv-tyagi · 2026-02-17T12:27:34Z

web/static/js/add_build.js

+  const params = new URLSearchParams(window.location.search);
+
+  // Rebuild flow ---
+  if (typeof rebuildFromBuildId !== "undefined") {


We can use params.has() and params.get() here as well.

shiv-tyagi · 2026-02-17T12:29:55Z

web/static/js/add_build.js

+      alert(
+        "Failed to load build configuration.\n\nRedirecting to new build page..."
+      );


Suggested change

alert(

"Failed to load build configuration.\n\nRedirecting to new build page..."

);

alert(

"Failed to load build configuration: " + error.message + "\n\nRedirecting to new build page..."

);

shiv-tyagi · 2026-02-17T12:33:35Z

web/static/js/add_build.js

+      rebuildConfig.vehicleId = data.vehicle?.id || null;
+      rebuildConfig.versionId = data.version?.id || null;
+      rebuildConfig.boardId = data.board?.id || null;
+      rebuildConfig.selectedFeatures = data.selected_features || [];
+      rebuildConfig.isRebuildMode = true;


We can't just fallback to null like this. See existing pattern and throw similar error to the user.

shiv-tyagi · 2026-02-17T12:35:02Z

web/static/js/add_build.js

+
+      const data = await res.json();
+
+      rebuildConfig.vehicleId = data.vehicle?.id || null;


We should call it preSelectConfig now.

shiv-tyagi · 2026-02-17T12:35:50Z

web/static/js/add_build.js

        for (let i=0; i<all_collapse_elements.length; i+=1) {
            let collapse_element = all_collapse_elements[i];
-            collapse_instance = bootstrap.Collapse.getOrCreateInstance(collapse_element);
+            let collapse_instance = bootstrap.Collapse.getOrCreateInstance(collapse_element);


Suggested change

let collapse_instance = bootstrap.Collapse.getOrCreateInstance(collapse_element);

collapse_instance = bootstrap.Collapse.getOrCreateInstance(collapse_element);

Not in this PR

shiv-tyagi · 2026-02-17T12:36:06Z

web/static/js/add_build.js


 function createCategoryCard(category_name, features_in_category, expanded) {
-    options_html = "";
+    let options_html = "";


Out of scope of this PR. Please remove this.

shiv-tyagi · 2026-02-17T12:36:13Z

web/static/js/add_build.js

    output.innerHTML =  '<label for="vehicle" class="form-label"><strong>Select Vehicle</strong></label>' +
                        '<select name="vehicle" id="vehicle" class="form-select" aria-label="Select Vehicle" onchange="onVehicleChange(this.value);"></select>';
-    vehicleList = document.getElementById("vehicle");
+    let vehicleList = document.getElementById("vehicle");


Out of scope of this PR.

shiv-tyagi · 2026-02-17T12:36:20Z

web/static/js/add_build.js

+    let vehicleList = document.getElementById("vehicle");
    vehicles.forEach(vehicle => {
-        opt = document.createElement('option');
+        let opt = document.createElement('option');


Out of scope of this PR.

ryanbasic1 force-pushed the feature/url-preselect-clean branch from f39ece1 to 9a111be Compare February 14, 2026 18:29

shiv-tyagi requested changes Feb 15, 2026

View reviewed changes

Refactor preselect logic per review: merge init flows and unify error…

9081dc1

… handling

shiv-tyagi requested changes Feb 17, 2026

View reviewed changes


		const data = await res.json();

		rebuildConfig.vehicleId = data.vehicle?.id \|\| null;

	let collapse_instance = bootstrap.Collapse.getOrCreateInstance(collapse_element);
	collapse_instance = bootstrap.Collapse.getOrCreateInstance(collapse_element);

Conversation

ryanbasic1 commented Feb 14, 2026

Example:

Uh oh!

shiv-tyagi commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shiv-tyagi left a comment

Choose a reason for hiding this comment

Uh oh!

shiv-tyagi Feb 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shiv-tyagi Feb 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

shiv-tyagi commented Feb 14, 2026 •

edited

Loading

shiv-tyagi Feb 15, 2026 •

edited

Loading

shiv-tyagi Feb 15, 2026 •

edited

Loading