make min PWM a configuration option to allow custom motor drivers #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
here is how I solved this, but I like your solution more |
timotto
force-pushed
the
feature/min-pwm-config
branch
from
1388527 to
14ba252
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AmMotorDriver class currently never sends a PWM value below 2 to brushless motor drivers to make sure the motor driver never receives a LOW level on the PWM signal input. This impacts the use of custom motor driver hardware requiring a value of 0 to stop the motor.
This pull requests adds the option
MOTOR_DRIVER_MIN_PWMtoconfig.hso a user can change this value to 0 when sensitive motor drivers are used.