refactor(season): move season tests to integration test file and add …#482
Merged
Olowodarey merged 2 commits intoArena1X:mainfrom Mar 29, 2026
Merged
Conversation
…transition test - Move all tests from contract/src/season_tests.rs to contract/tests/season_tests.rs - Update imports to use insightarena_contract:: crate path - Remove #[cfg(test)] mod season_tests declaration from lib.rs - Delete contract/src/season_tests.rs - Add test_season_transition_preserves_data: verifies historical season data (leaderboard snapshot, reward pool, top winner) is preserved after a new season is created and activated Closes Arena1X#325
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@Sendi0011 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move Season Tests to Integration Test File + Add Transition Test
Closes #325
What changed:
contract/src/season_tests.rsinto a newcontract/tests/season_tests.rsintegration test file, consistent with howescrow_tests,invite_tests, and others are structuredcrate::toinsightarena_contract::(external crate path)#[cfg(test)] mod season_tests;declaration fromlib.rscontract/src/season_tests.rstest_season_transition_preserves_data: creates two sequential seasons, finalizes the first, then asserts the finalized season's data (leaderboard snapshot, reward pool, top winner) remains intact after the second season is created and activatedWhy:
Inline test modules in
src/bypass integration boundaries. Moving totests/ensures season logic is tested through the public contract API, matching the project's established pattern.