feat(#373-#376): Implement calculate_liquidity_value function and com…#501
Merged
Olowodarey merged 7 commits intoArena1X:mainfrom Mar 30, 2026
Merged
Conversation
…nction and comprehensive tests - Implement calculate_liquidity_value for LP token redemption (Arena1X#373) - Add 4 basic liquidity value calculation tests (Arena1X#373) - Add 4 edge case tests for multiple LPs and large pools (Arena1X#374) - Add 4 validation tests for error handling (Arena1X#375) - Add 1 precision test for rounding accuracy (Arena1X#376) Total: 13 new tests covering all scenarios including: - Full and partial withdrawals - Fee accumulation - Multiple LP positions - Small and large pool operations - Zero/negative token validation - Supply overflow protection - Precision verification
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@Lex-Studios Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Liquidity Value Calculation Function
Implement
calculate_liquidity_valuefor LP token redemption with comprehensive test coverage.Changes
calculate_liquidity_valuefunction for LP token withdrawal calculationsTests Added
Closes #373
Closes #374
Closes #375
Closes #376