Port the new GTM sync API to 1.21 so it can be used in this mod#16
Merged
Port the new GTM sync API to 1.21 so it can be used in this mod#16
Conversation
…former and add more sanity checks
…we expect it to have
…tively support too
screret
added
type: feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This is a port of the new annotation based save/sync API that is going to be in GTM 8.0.0.
Implementation Details
Mostly a direct port, though I changed around certain parts to be more akin to how I like them. Mostly formatting.
Outcome
waow!! I dont need to write sync code manually now!!
Additional Information
The GTM specific code and constructs were removed.