feat: calculate coordinates on circle with respect to bounding client rect #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rect The `calculateCoordinatesOnCircle` function now accepts an additional parameter `boundingClientRect` which represents the bounding client rectangle of the element. This allows for accurate positioning of the coordinates on the circle taking into account the element's width and height. The `x` and `y` coordinates are now calculated based on the `centerX` and `centerY` values, which are derived from the original calculations. The `transform` property has been removed from the inline styles since it is no longer needed. Additionally, a `ref` has been added to the `div` element to reference the `orbitItemRef` for later use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
calculateCoordinatesOnCirclefunction now accepts an additional parameterboundingClientRectwhich represents the bounding client rectangle of the element. This allows for accurate positioning of the coordinates on the circle taking into account the element's width and height. Thexandycoordinates are now calculated based on thecenterXandcenterYvalues, which are derived from the original calculations. Thetransformproperty has been removed from the inline styles since it is no longer needed. Additionally, arefhas been added to thedivelement to reference theorbitItemReffor later use.