Added support to sync Labels with content models.#28
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for syncing labels with content models by updating the schema normalization function to preserve label information during serialization and deserialization cycles.
Changes:
- Updated the
normalizefunction to extract and conditionally include thelabelsfield from schemas - Added comprehensive test coverage for label preservation in normalized schemas
- Added test coverage for schema equivalence comparisons with labels
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cli/src/schema/normalize.ts | Added labels parameter extraction and conditional inclusion in normalized schema output, with updated documentation |
| cli/src/schema/normalize.test.ts | Added two new tests to verify labels are preserved when present and not added when absent |
| cli/src/schema/isEquivalentSchema.test.ts | Added two new tests to verify schema equivalence behavior with different and same labels |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Bill Cacy <98779849+ArkeBcacy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support to sync Labels with content models.