UI image system(s) rework #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely overhauls/rewrites the UI's image loader/downloader system(s), which were easily the worst part of the UI. Also does some generic speed-ups for the bridge as a whole.
Provides a new API to interact with the image loader in a self-contained way; files exist on disk, backend/bridge pushes URLs to the image cache to account for if they don't; cache figures it all out and exposes a
getfunction to the UI which returns anOption<TextureHandle>, versatile enough to work in every situation the previous system(s) worked in.May conflict with #19, but i put
Backgroundas a supported image type so that branch/feature can take advantage of it.